From 27a6c9cfd4b44b5313cd866108f88903aaf5111a Mon Sep 17 00:00:00 2001
From: Lucas Werkmeister <mail@lucaswerkmeister.de>
Date: Fri, 22 Apr 2016 20:44:52 +0200
Subject: [PATCH] Use Bash arrays instead of word splitting

Just in case we ever want to use spaces in any of those places.
---
 collectCRLs         | 2 +-
 collectGigiConfig   | 4 ++--
 collectSignerConfig | 8 ++++----
 generateCRLs        | 2 +-
 generateHtdocs      | 6 +++---
 generateKeys        | 2 +-
 generateTime        | 4 ++--
 structure.bash      | 6 +++---
 verify              | 6 +++---
 9 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/collectCRLs b/collectCRLs
index a7818d7..dc3f7cc 100755
--- a/collectCRLs
+++ b/collectCRLs
@@ -23,7 +23,7 @@ for month in {01..12}; do
     BASE=crls-${year}/$year-$month
     mkdir -p $BASE
     cp root.ca/${year}_${month}.crl $BASE/root.crl
-    for ca in $STRUCT_CAS; do
+    for ca in "${STRUCT_CAS[@]}"; do
         cp $ca.ca/${year}_${month}.crl $BASE/$ca.crl
     done
 done
diff --git a/collectGigiConfig b/collectGigiConfig
index 7104115..27591d2 100755
--- a/collectGigiConfig
+++ b/collectGigiConfig
@@ -9,9 +9,9 @@ cd generated
 
 mkdir -p gigi-config/config/ca
 cp root.ca/key.crt gigi-config/config/ca/root.crt
-for ca in $STRUCT_CAS; do
+for ca in "${STRUCT_CAS[@]}"; do
     cp ${ca}.ca/key.crt gigi-config/config/ca/${ca}.crt
-    for i in $TIME_IDX; do
+    for i in "${TIME_IDX[@]}"; do
         cp ${year}/ca/${ca}_${year}_${i}.crt gigi-config/config/ca/${ca}_${year}_${i}.crt
     done
 done
diff --git a/collectSignerConfig b/collectSignerConfig
index f00b088..b8e0f91 100755
--- a/collectSignerConfig
+++ b/collectSignerConfig
@@ -8,8 +8,8 @@ year=$1
 cd generated
 
 mkdir -p signer-config
-for ca in $STRUCT_CAS; do
-    for i in $TIME_IDX; do
+for ca in "${STRUCT_CAS[@]}"; do
+    for i in "${TIME_IDX[@]}"; do
         mkdir -p signer-config/ca/${ca}_${year}_${i}
         cp ${year}/ca/${ca}_${year}_${i}.crt  signer-config/ca/${ca}_${year}_${i}/ca.crt
     done
@@ -19,8 +19,8 @@ tar czf signer-client-$year.tar.gz -C .. profiles -C generated/signer-config ca
 
 # Updating for server
 
-for ca in $STRUCT_CAS; do
-    for i in $TIME_IDX; do
+for ca in "${STRUCT_CAS[@]}"; do
+    for i in "${TIME_IDX[@]}"; do
         cp ${year}/ca/${ca}_${year}_${i}.key  signer-config/ca/${ca}_${year}_${i}/ca.key
     done
 done
diff --git a/generateCRLs b/generateCRLs
index ff2338b..5d90894 100755
--- a/generateCRLs
+++ b/generateCRLs
@@ -43,6 +43,6 @@ generateYearCRLs (){ #name idx
     done
 }
 generateCRLs root
-for ca in $STRUCT_CAS; do
+for ca in "${STRUCT_CAS[@]}"; do
     generateCRLs $ca
 done
diff --git a/generateHtdocs b/generateHtdocs
index 78a0976..3a039f2 100755
--- a/generateHtdocs
+++ b/generateHtdocs
@@ -8,12 +8,12 @@ cd generated
 
 mkdir -p htdocs/crt/g2/$year
 
-for ca in root $STRUCT_CAS; do
+for ca in root "${STRUCT_CAS[@]}"; do
     cp $ca.ca/key.crt htdocs/crt/g2/$ca.crt
 done
 
-for ca in $STRUCT_CAS; do
-    for i in $TIME_IDX; do
+for ca in "${STRUCT_CAS[@]}"; do
+    for i in "${TIME_IDX[@]}"; do
         cp $year/ca/${ca}_${year}_${i}.crt htdocs/crt/g2/$year/${ca}-${i}.crt
     done
 done
diff --git a/generateKeys b/generateKeys
index d978bfb..321be23 100755
--- a/generateKeys
+++ b/generateKeys
@@ -56,7 +56,7 @@ genca "/CN=Cacert-gigi testCA" root
 rootSign root
 
 # generate the various sub-CAs
-for ca in $STRUCT_CAS; do
+for ca in "${STRUCT_CAS[@]}"; do
     . ../CAs/$ca
     genca "/CN=$name" $ca
     rootSign $ca
diff --git a/generateTime b/generateTime
index d5e8553..6f2572d 100755
--- a/generateTime
+++ b/generateTime
@@ -35,7 +35,7 @@ TESTCA
 mkdir -p $year/ca
 
 
-for i in $TIME_IDX; do
+for i in "${TIME_IDX[@]}"; do
     point=${year}${points[${i}]}
     nextp=${points[$((${i} + 1))]}
     if [[ "$nextp" == "" ]]; then
@@ -44,7 +44,7 @@ for i in $TIME_IDX; do
         epoint=$((${year} + 2 ))${epoints[${i}]}
     fi
 
-    for ca in $STRUCT_CAS; do
+    for ca in "${STRUCT_CAS[@]}"; do
         . ../CAs/$ca
         genKey "/CN=$name ${year}-${i}" $year/ca/${ca}_${year}_${i}
         genTimeCA $year/ca/${ca}_${year}_${i} $ca "$point" "$epoint"
diff --git a/structure.bash b/structure.bash
index 3657f07..57426b1 100644
--- a/structure.bash
+++ b/structure.bash
@@ -5,9 +5,9 @@ PRIVATEPW="changeit"
 
 [ -f config ] && . ./config
 
-STRUCT_CAS="env unassured assured codesign orga orgaSign"
-SERVER_KEYS="api secure www static signer_server signer_client mail"
-TIME_IDX="1 2"
+STRUCT_CAS=(env unassured assured codesign orga orgaSign)
+SERVER_KEYS=(api secure www static signer_server signer_client mail)
+TIME_IDX=(1 2)
 points[1]="0101000000Z"
 points[2]="0601000000Z"
 
diff --git a/verify b/verify
index 092e52e..6e97709 100755
--- a/verify
+++ b/verify
@@ -42,14 +42,14 @@ verify root.ca/key.crt
 verifyExtlist "$(openssl x509 -in "root.ca/key.crt" -noout -text)" root
 
 # Verify level-1 structure
-for ca in $STRUCT_CAS; do
+for ca in "${STRUCT_CAS[@]}"; do
     verify $ca.ca/key.crt
     verifyExtlist "$(openssl x509 -in "$ca.ca/key.crt" -noout -text)" "$ca"
 done
 
 # Verify level-2 (time) structure
-for ca in ${STRUCT_CAS}; do
-    for i in $TIME_IDX; do
+for ca in "${STRUCT_CAS[@]}"; do
+    for i in "${TIME_IDX[@]}"; do
         . ../CAs/$ca
         CA_FILE=$year/ca/${ca}_${year}_${i}.crt
         time=${points[${i}]}
-- 
2.47.3